-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Has this been abandoned? #1427
Comments
The last bunch of merged pull requests were merged after half a year of inactivity, so it's hard to say. |
I honestly don't know, I've tweeted at the developer asking if he needs donations to keep working on this and so forth but have never received a response. |
Yeah none of the forks have continued to be maintained. |
I'll try my hand at continuing it a bit by simply merging other peoples merge requests into my repository. I know some python, but I have zero experience with bigger projects like this one, so if you want to help/join/collaborate, feel free to ask & I'll set you as admin or whatever it's called on here. |
@noodle- Yeah add me in. I'm proposing the following remediation plan of action:
My only experience with working on a large project is https://github.com/saltstack/salt/, and I've learned the following from that: Prioritize proper release naming, no bugs on releases, and proper issue/PR handling over anything else. If we can get more people who are good with Python involved that would be beneficial. My Python is okay but I am by no means a grade A developer. |
I'm in for testing/validating on Windows OS From: Forrest notifications@github.com @noodle-https://github.com/noodle- Yeah add me in. I'm proposing the following remediation plan of action:
My only experience with working on a large project is https://github.com/saltstack/salt/, and I've learned the following from that: Prioritize proper release naming, no bugs on releases, and proper issue/PR handling over anything else. If we can get more people who are good with Python involved that would be beneficial. My Python is okay but I am by no means a grade A developer. You are receiving this because you are subscribed to this thread. |
This reminds me that once we have things in a reasonable state we should notify these guys: https://github.com/bastimeyer/livestreamer-twitch-gui They are actually maintaining their project and deserve to be notified if we're going to get updates in. Actually maybe their community is interested in helping. @bastimeyer I'm adding you onto this conversation. If you have any Python devs you know that love livestreamer we could use some help. |
Maybe even ask them for help with it? On Aug 10, 2016 9:49 AM, "Forrest" notifications@github.com wrote:
|
@Junior1544 I edited my message to mention the primary maintainer. |
@Junior1544 My plan was more along the lines of
So maybe it's better if you set up the (new) main repository and add me as little helper instead. I don't have time to do much, but I'd be happy to help & learn wherever I can. |
Thanks for mentioning me here and letting me know... It's a shame that Chrippa seems to have abandoned his project. Personally, I would welcome a fork with all necessary bugfixes and having an assurance that it's being maintained if something breaks and gets fixed in time. We don't have this now and it's quite scary, because it might break any day. Having a working and maintained fork would save me from reimplementing something similar to livestreamer in my application. The last time something broke regarding viewing Twitch streams, it was fixed within a couple of hours, back in early december 2014. I've heard that there are currently some issues with certain VODs on Twitch that livestreamer is unable to read correctly. That's a problem for the future plans of my application. There are also a couple of player argument parsing bugs in the current version that are around for quite some time. As I've already said, I'm fine with the idea of a fork, but I don't know how you are planning to do this.
|
I have no idea on where to even start, otherwise I would have done it Sorry. On Aug 10, 2016 10:58 AM, "Nils" notifications@github.com wrote:
|
I think a new fork with new maintainers might be a good idea at this point. Also sorry to say that my fork is quite a lot of extra code and I didn't write any tests for it. It probably needs tidying up quite a bit. I used a lot of threading, and it's prone to deadlock issues. The mailbox behavior should be changed to work like a golang channel to make it a bit more consistent. When I wrote it I was trying to add code without changing too much existing stuff. A lot of it could probably be rewritten to be a lot simpler. |
I don't know much about the code of this project but in general I would like to help with this. I would be a lousy maintainer, but if there are open issues in a fork I might take a look at it. |
I've posted some stuff about the issues I currently have with my own fork over at #1311 I think anyone looking at creating a new fork of this would need to be quite dedicated to it. There are a lot of things to think about like, a new website, checking any licensing issues, setting up continuous integration / deployment of binaries, documentation, making sure there is good test coverage, making sure the tests are actually useful, making sure you don't accept any pull requests into master that would break anything, and continued development of the project. I think it would be a good idea for anyone serious about making a new fork to create a Patreon page to support the core maintainers of the package, so that there is something to justify their time input other than "just being a cool project". The fork I made was my first real crack at making some fairly significant changes to an open source project, and it was a lot more work than I thought it would be. In saying that, you will learn a lot of useful stuff doing this, I'd be tempted to do this myself if I thought I would get good Patreon support and could keep my hours to say 10 hours a week. |
@FurryFur This has been my main concern when I considered taking this over almost a year ago after @chrippa didn't respond even after I asked about donations to the project. It's a big project to take over, and I honestly don't know if the community that uses Livestreamer is even willing to donate to make the amount of work required to maintain it tenable. Even 10 hours a week is a LOT of hours, and for most software developers that's easily a couple grand a month to maintain. I already spend a good chunk of time on one open source project and have received a total of $0 and 3 free meals for my work. |
I don't know about anyone else, but i'd donate to a good developer (or Hopefully someone can get this thing going again, or maybe @chrippa will Thanks guys and girls! this whole discussion is giving me at least some --James James Hauge On Thu, Aug 11, 2016 at 6:29 AM, Forrest notifications@github.com wrote:
|
As a side note, youtube-dl is another maintained free software project that does have much of the same functionality (though it's more focused on downloading as opposed to streaming.) |
Hey @Junior1544 -- there is an easy way to make livestream.com streams work -- just open the page that's streaming, and use CTRL+U (assuming you're in Google Chrome) then press CTRL+F (for "find") and search for .m3u8. Take that full URL (including all of the code after it, up until the closing quotes) and that will be the stream URL for livestreamer. Request it with the hlsvariant:// prefix and you're golden. From: Junior1544 notifications@github.com I don't know about anyone else, but i'd donate to a good developer (or Hopefully someone can get this thing going again, or maybe @chrippa will Thanks guys and girls! this whole discussion is giving me at least some --James James Hauge On Thu, Aug 11, 2016 at 6:29 AM, Forrest notifications@github.com wrote:
You are receiving this because you commented. |
Thanks @scottbernstein !! But, I just gave that a shot, and am getting a the live stream i'm trying to play can be viewed directly on this url: and the livestream command i tried is: I also tried putting quotes around the whole url because it was giving me Thanks! James Hauge On Thu, Aug 11, 2016 at 8:34 AM, scottbernstein notifications@github.com
|
That should work -- with 2 caveats:
In fact, I just validated your video stream from the URL you used and it worked perfectly. Most important thing is to refresh the page and grab the m3u8 link JUST before you issue the livestreamer command. From: Junior1544 notifications@github.com Thanks @scottbernstein !! But, I just gave that a shot, and am getting a the live stream i'm trying to play can be viewed directly on this url: and the livestream command i tried is: I also tried putting quotes around the whole url because it was giving me Thanks! James Hauge On Thu, Aug 11, 2016 at 8:34 AM, scottbernstein notifications@github.com
— |
Thank you @scottbernstein It's not for a windows computer. it's for use with Linux, the Raspberry Pi... And, I did it within a minute... but, I also need something that'll work for longer than 1 minute, that's why I was hoping that this program was going to start being supported again... I was told that there was a solution that works, but I don't know how to put it into place, it's a change to a few lines of the code... it's listed at #1277 Thanks... |
yes, I have also confirmed that pull request #1277 will work From: Junior1544 notifications@github.com Thank you @scottbernsteinhttps://github.com/scottbernstein It's not for a windows computer. it's for use with Linux, the Raspberry Pi... And, I did it within a minute... but, I also need something that'll work for longer than 1 minute, that's why I was hoping that this program was going to start being supported again... I was told that there was a solution that works, but I don't know how to put it into place, it's a change to a few lines of the code... it's listed at #1277#1277 Thanks... You are receiving this because you were mentioned. |
@Junior1544 @scottbernstein Could you guys please stop commenting on that other issue in this thread? It isn't relevant for the current topic. |
Reading the comments above, it seems that no one has the time to properly maintain the overall project, but at the same time there's interest in contribute to it from several people. Looking at the forks' map (https://github.com/chrippa/livestreamer/network), it seems several devs work regularly on their forks recently (ie @FurryFur @intact @steven7851 ); so maybe a workable strategy would be to integrate those forks as a loosely organized continuation effort? (and invite whoever is submitting PRs in this original project to do it in the continuation as well to add valuable community efforts?) Just thinking aloud... |
@WolfganP Yes, someone who's able & willing will have to step forward to do the honours of hosting the main project/repository though. |
@WolfganP The main problem is whoever is the primary maintainer is going to have a lot of work to do no matter what. We're talking at least a full 40 hours just to get the project back into the barest of shape with merging and reviewing PRs. The work has built up over time unfortunately so now we're in this shitty spot. |
How scary is the codebase on this thing? Looked at a few files and the py3 compatibility looks a bit hackish. I was going to use this as an example or fork/refactor in my crazy media stream/transcode suite...but now I'm not so sure. Don't know if I want to walk into 500 bug/issues and 50 pr's. heh |
@bastimeye brings up good points. I have a Jenkins/Proxmox that could possibly be throw into the mix for build/vm, CI, etc.....we'll see. |
@SpootDev I've started several issues over in the other repo to address these points. We should be able to push most of that stuff through Travis to ensure that it stays open and accessible to everyone. |
Really, it's a bad idea to change the name of the project. Are you sure you can't simply maintain a new branch "proposed-updates" or something along the lines and merge all the pending patches over there? |
@javiercantero the problem is that since this has been abandoned, we can't maintain / update the packages that are currently on CentOS / Debian / Ubuntu / etc. With a new name (as well as an org instead of a user) we have more control whether this project is abandoned again in the future, etc. |
Everyone check your invites, I've added everyone to the org with admin access to http://github.com/streamlink/streamlink if you feel that you need to add another collaborator with push access, etc, feel free to you (should) have the permission to do so. Keep in mind that the permissions (admin) is very lenient, I'd like us to be as open as possible. Luckily with the power of Git, if someone were to be toxic it's a quick |
@cdrage You don't have to maintain the packages, the distro package maintainers will do it. Believe me, it's going to be more difficult to add a new package to Debian in time for the next stable release (the freeze is in 3 months and the package should be accepted and be ready before that) that to convince the current livestreamer Debian maintainter to add some patches downstream (this applies not only to Debian but also to any derivative including Ubuntu since the Debian package is the basis for the rest). |
While others are busy talking about doing things and therefore not actually doing anything, I went through all the pull requests and merged most of them into the master branch of my repo. Included are:
and these didn't get in:
Now I'm trying to find out how to upload a release tarball here, so that all the Technologically Impaired Ducks using the program can get a working version without needing to deal with git... Also, hasn't anyone noticed that the streamlink repository is cloned from master rather than develop branch and therefore is missing all commits between 1.12.2 release and the last merge at March of this year? |
I disagree, when the community agrees that changes need to happen I think the best way is to completely fork it and start a new project, but honor the legacy from which it came. LibreOffice is a good example in my mind. |
@sondr3 That only applies when a community splits in two different ways. That's not what is happening here. |
A tarball + Windows installation instructions are now available here. Again, it's meant to be a temporary solution until the streamlink folks have a better release available. |
@LoneFox78 Don't bother with any PR < 1192 (the last one merged by chrippa) |
Hey @LoneFox78 thank you so much for all the work you've done for your fork / branch. IMO, we should still fork / split as unfortunately we can't get anything merged into livestreamer as @chrippa has abandoned it. A good start would be to merge your branch / fork into streamlink. I've created the PR streamlink/streamlink#9 so we can have a great starting point / code-base for everything. |
I'm just a bystander, but my two cents: While it would be ideal to receive stewardship of the project from @chrippa, in the absence of that, forking and renamin g is the only viable path forward. If this, the canonical repo for livestreamer, is to remain stuck, there must be a new name for the fork to distinguish it. |
#1495 is my own selection of urgent fixes. It's based on the list provided by @LoneFox78 above but shorter since it doesn't include new code, new features or new plugins, only fixes for existing plugings. My goal is to try to convince the Debian maintainers to include the patch in the livestreamer package for the next release of Debian (9.0) before it is too late. This also should affect any derivative of Debian (including Ubuntu and its derivatives). Any testing of the patched plugins is greatly appreciated. |
@javiercantero How long do we have for the Debian release? We've got a working release of streamlink that we might be able to push if we can package it up. |
@gravyboat The hard deadline for the "freeze" of Debian Stretch is January 5, 2017 but I recommend you to start ASAP (since I don't know if the inclusion of new packages is welcome so close to the freeze date). EDIT: simply to confirm that the deadline for new packages is January 5th 2017 |
The joy of slow moving projects, 3 months to go is 'close' to the freeze date. |
@javiercantero Thanks for your effort to get the patches into Debian. As a Debian user, I appreciate it! |
@gravyboat The whole process is (at least) two years, so 3 months is really close :) |
I am the author of the twitchlive extension for gnome shell (https://github.com/maweki/twitchlive-extension) and for now I will be pointing people to streamlink |
@LoneFox78 |
@grazzolini That looks like a very nice addition! I agree that it seems like few lines for adding such a feature. Well done. |
@giancarlo -- please issue the same pull request to the Streamlink project which has taken over development of livestreamer as an active project: https://github.com/streamlink/streamlink [https://avatars0.githubusercontent.com/u/22243823?v=3&s=400]https://github.com/streamlink/streamlink GitHub - streamlink/streamlink: CLI for extracting streams ...https://github.com/streamlink/streamlink It started off with the same code base and has only recently started making some changes From: Giancarlo Razzolini notifications@github.com @LoneFox78https://github.com/LoneFox78 You are receiving this because you were mentioned. |
I tested streamlink and it's just the most user unfriendly BS ever (for Windows). There is no prebuild Windows build just some nonsense GUI which downloads and (compiles) it together, first nonsense BS. Then there is no config file to find like it was in livestreamer, to define which player should be used, VLC ect. Then how to use it ? Just replaced livestreamer.exe with the streamlink.exe doesn't work ... it seems not to support the same commands. This is unbelievable. |
@makedir Perhaps you should make a new issue in the Streamlink repo with your issue with a coherent statement of your problems rather than necro posting in this thread on an abandoned project. You'll be much more likely to get help over there. |
Yes, Please raise an issue over at Streamlink Livestreamer was forked several months ago and has understandably changed a bit to meet changes in API's and to meet the needs of those using it. But let's discuss your concerns over at Streamlink. :) |
For me (on Windows), Streamlink has been exactly a drop in replacement. Sorry it doesn't work for you....
On Apr 7, 2017, at 11:31 AM, fishscene <notifications@github.com<mailto:notifications@github.com>> wrote:
Yes, Please raise an issue over at Streamlink<https://github.com/streamlink/streamlink/issues>
Livestreamer was forked several months ago and has understandably changed a bit to meet changes in API's and to meet the needs of those using it. But let's discuss your concerns over at Streamlink. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1427 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AESJ1rPa2sH6zCKdCF1rWvgThq9ekYvNks5rtla9gaJpZM4JeurO>.
|
@LoneFox78 Castamp is not mobile only, it just does not have public streams. Also, it's not untestable, I even have an example of testing it here: https://github.com/rbong/livestreamer-nightly/tree/castamp However it has been several years since I used this software so I will likely not be porting it over to your fork, so if someone wants castamp support unfortunately they will have to add it themselves. |
This software looks like it hasn't been updated by the person in control of it in over a year...
Has it been abandoned? Is there someone else out here that'd start a new git and implement the updates that there are pull's for and keep it going under a new name??
I would myself, except I'm still new to Github and really don't know what I'm doing yet...
Thanks!
The text was updated successfully, but these errors were encountered: