-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nan v1.8.4 for io.js 2.0.0 compatibility #61
Conversation
FWIW this doesn't fix it (here). The API changed between 1.5.3 -> 1.8.4 and causes failure. |
@KenanSulayman I'm able to get dtrace-provider to compile with nan So it is true that there is deprecation warning about usage of
Use of this deprecated symbol should be addressed by someone familiar with |
Referencing nodejs/node#1620 |
The change was in node 0.11.4 or so, but the deprecation warning never showed due to a bug in Node. #if NODE_MODULE_VERSION < 12
FatalException(try_catch);
#else
FatalException(Isolate::GetCurrent(), try_catch);
#endif |
This PR is about just bumping nan dependency to Use of deprecated nan features can be fixed later; maybe with preprocessor conditional solution @kkoopa offered. |
I've confirmed that this patch both builds and passes tests with Node v0.12.2 and v0.10.30 on SmartOS, but the tests don't seem to work at all on OS X using v0.12.0. |
This PR needs some attention. |
Tests on OS X fail on io.js 1.8.1 and node.js 0.10.38 just the same, so I'm not sure if this broken anyway, and unrelated to the PR. |
I dug into the test failures and realized it was that they need to be run with sudo on OS X. Just published v0.5.0 with this merge. Thanks! |
Compiling dtrace-provider
0.4.0
fails with io.js2.0.0
:This PR updates
nan
to version1.8.4
allowing compilation with latest io.js version.