Skip to content

Commit

Permalink
Fixed #66; crash when injecting into 32 bit cmd
Browse files Browse the repository at this point in the history
Turning on exception support for the whole project in v1.1.21 broke the
remote thread injection code, but only for 32 bit final release builds.

Now exception support is off by default for the whole project, is forced
off for the remote thread injection code, and is only turned on for the
terminal code that actually needed it in order to support regular
expressions in `console.findprevline()` and `console.findnextline()`.
  • Loading branch information
chrisant996 committed Jan 29, 2021
1 parent 7e7957e commit 3dd4f49
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 5 additions & 1 deletion CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,12 @@
- Special quote handling now enables `"dir\"fi` to complete to `"dir\file"`. CMD simply strips quotes during completion, and now Clink behaves similarly.
- <strong>Breaking Change:</strong> `line:getword()` and `line:getendword()` now strip quotes from the word. This should generally automagically make existing match generators work even with embedded quotes, but there's a chance that some match generator might need to be updated. This seems like a reasonable compromise, given the general benefit purchased by this breaking change.
- `os:globdirs()` and `os:globfile()` strip quotes from the <span class="arg">globpattern</span> in order to behave more like CMD. Embedded quotes are nonsensical and the intended interpretation is clear, so the APIs now help out with that.
- Fixed [#66](https://github.com/chrisant996/clink/issues/66); crash when injecting into 32 bit cmd.
- Fixed [#64](https://github.com/chrisant996/clink/issues/64); wrong cursor position when PROMPT contains BEL character.
- Fixed [#62](https://github.com/chrisant996/clink/issues/62); argmatchers should color `-x:"foo"` as a flag if `-x:` is a flag.
- Fixed [#61](https://github.com/chrisant996/clink/issues/61); argmatchers should not handle completion for text immediately following `-flag:`. Instead it always uses file completion. A custom generator can be used to override that behavior.
- Fixed [#60](https://github.com/chrisant996/clink/issues/60); completion fails with multiple slashes.
- Fixed completion in some circumstances. Readline and Clink didn't always agree on where the word breaks were; now Clink always tell Readline where the word breaks are (which is important so that completion, input colorization, and lua scripts can all work properly and consistently).
- Fixed completion in some circumstances. Readline and Clink didn't always agree on where the word breaks were; now Clink always tells Readline where the word breaks are (so that completion, input colorization, and lua scripts can all work properly and consistently).
- Fixed 256 color ANSI codes.

### v1.1.23
Expand Down
4 changes: 3 additions & 1 deletion premake5.lua
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ workspace("clink")
staticruntime("on")
rtti("off")
symbols("on")
exceptionhandling("on") -- for std::wregex
exceptionhandling("off")
defines("HAVE_CONFIG_H")
defines("HANDLE_MULTIBYTE")
defines("CLINK_COMMIT="..clink_git_commit)
Expand Down Expand Up @@ -226,6 +226,7 @@ clink_lib("clink_terminal")

includedirs("clink/terminal/src")
configuration("vs*")
exceptionhandling("on") -- for std::wregex
pchheader("pch.h")
pchsource("clink/terminal/src/pch.cpp")

Expand All @@ -244,6 +245,7 @@ clink_lib("clink_process")
inlining("auto") -- required by the inject lambda in process::remote_call
editAndContinue("off") -- required by the inject lambda in process::remote_call
omitframepointer("off") -- required by the inject lambda in process::remote_call
exceptionhandling("off") -- required by the inject lambda in process::remote_call
-- <SupportJustMyCode>false</SupportJustMyCode> -- required by the inject lambda in process::remote_call

--------------------------------------------------------------------------------
Expand Down

0 comments on commit 3dd4f49

Please sign in to comment.