Fix crash caused by destruction of non detached threads #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an async_lua_task is erase()'d from the task_manager's m_map, the accompanying std::thread is destroyed. In the event that the task_manager::on_idle is called before async_lua_task::proc has finished it's do_work() in order to detach() the task thread, a crash is caused in the async_lua_task's destructor by the m_thread's destructor as that sees that the thread is not marked as joined or detached
As per std::unordered_map::erase documentation, return value is the iterator following the last removed element, so any intermediate next iterators are not necessary
chrisant996
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
async_lua_taskiserase()'d from thetask_manager'sm_map, the accompanyingstd::threadis destroyed.In the event that the
task_manager::on_idleis called beforeasync_lua_task::prochas finished it'sdo_work()in order todetach()the task thread, a crash is caused in theasync_lua_task's destructor by them_thread's destructor as that sees that the thread is not marked as joined or detached.The behavior has been noticed on machines with weak compute cores (virtual machines specifically) and on heavily overloaded hosts, such as development machines during heavy compilation duty.
Problem has been traced with debug builds and WinDbg and fixes are tested and work on the affected machines above.