Calculate areas in screen coordinates #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to support things like Dialogs, which use a separate native window on Android. Currently we calculate everything in root composable coordinates, which does not work across window boundaries.
ZacSweers
referenced
this pull request
in ZacSweers/CatchUp
Jan 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dev.chrisbanes.haze:haze](https://togithub.com/chrisbanes/haze) | `0.4.3` -> `0.4.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chrisbanes/haze (dev.chrisbanes.haze:haze)</summary> ### [`v0.4.5`](https://togithub.com/chrisbanes/haze/releases/tag/0.4.5) [Compare Source](https://togithub.com/chrisbanes/haze/compare/0.4.4...0.4.5) #### Changes - Android Previews (and screenshot tests) now display a scrim, rather than nothing. - Haze children from different Android windows (i.e. Dialogs) now work #### What's Changed - Calculate areas in screen coordinates by [@​chrisbanes](https://togithub.com/chrisbanes) in [https://github.com/chrisbanes/haze/pull/88](https://togithub.com/chrisbanes/haze/pull/88) - Update dependency androidx.compose.ui:ui to v1.6.0-rc01 by [@​renovate](https://togithub.com/renovate) in [https://github.com/chrisbanes/haze/pull/90](https://togithub.com/chrisbanes/haze/pull/90) - Merge Android implementations by [@​chrisbanes](https://togithub.com/chrisbanes) in [https://github.com/chrisbanes/haze/pull/91](https://togithub.com/chrisbanes/haze/pull/91) **Full Changelog**: chrisbanes/haze@0.4.4...0.4.5 ### [`v0.4.4`](https://togithub.com/chrisbanes/haze/releases/tag/0.4.4) [Compare Source](https://togithub.com/chrisbanes/haze/compare/0.4.3...0.4.4) #### What's Changed - Fix hazeChild tint not updating on Android base by [@​chrisbanes](https://togithub.com/chrisbanes) in [https://github.com/chrisbanes/haze/pull/83](https://togithub.com/chrisbanes/haze/pull/83) - Update plugin mavenpublish to v0.27.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/chrisbanes/haze/pull/84](https://togithub.com/chrisbanes/haze/pull/84) - Add screenshot tests to verify `hazeChild` tint changes by [@​chrisbanes](https://togithub.com/chrisbanes) in [https://github.com/chrisbanes/haze/pull/85](https://togithub.com/chrisbanes/haze/pull/85) **Full Changelog**: chrisbanes/haze@0.4.3...0.4.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ZacSweers/CatchUp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to support things like Dialogs, which use a separate native window on Android. Currently we calculate everything in root composable coordinates, which does not work across window boundaries.
Fixes #86