This repository has been archived by the owner on Nov 12, 2024. It is now read-only.
Deflake baseline profile generation #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently I was trying to re-use UiObjects but that seems to be a bit flakey.
This might slow the test down, but it should be less flakey
chrisbanes
force-pushed
the
cb/deflake-baseline-profile-gen
branch
2 times, most recently
from
42812b2 to
38fad2d
Compare
Needs to be reverted before landing
This reverts commit 76dbdc0.
chrisbanes
force-pushed
the
cb/deflake-baseline-profile-gen
branch
from
a246188 to
8d92522
Compare
This reverts commit 595da97.
chrisbanes
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by a few issues: