Migrate to moviebaseapp/tmdb-api

[chrisbanes]

Fixes #1092

[ChrisKruegerDev]

Two things to add in the TMDB lib:

• Retrying failed requests (https://ktor.io/docs/client-retry.html)
• Error handling for not found TMDB resources by a show ID

For TMDB, there isn't a request limit anymore. So we don't need an extra retry mechanism. See https://developers.themoviedb.org/3/getting-started/request-rate-limiting

However, you may want to handle exceptions from the ktor request (ResponseException).

[chrisbanes]

For TMDB, there isn't a request limit anymore. So we don't need an extra retry mechanism. See https://developers.themoviedb.org/3/getting-started/request-rate-limiting

Nice. The retry handling was more for Trakt iirc.

Another thing I was thinking about was re-using my OkHttp client. Currently the creation of the Ktor client is private in Tmdb3, so I can't set the http engine. Maybe we could add a (userConfig: HttpClientConfig) -> HttpClient constructor param?

[ChrisKruegerDev]

Another thing I was thinking about was re-using my OkHttp client. Currently the creation of the Ktor client is private in Tmdb3, so I can't set the http engine. Maybe we could add a (userConfig: HttpClientConfig) -> HttpClient constructor param?

I thought something similar. For the entire OkHttp engine support, we need to open the library more. We can pass your own HTTP client instance and add the TMDB config on top.

https://ktor.io/docs/http-client-engines.html#okhttp

[chrisbanes]

For the entire OkHttp engine support, we need to open the library more. We can pass your own HTTP client instance and add the TMDB config on top.

Not necessarily. We can just rely on the implicit engine discovery (https://ktor.io/docs/http-client-engines.html#default), which is what I'm using right now. The important part is being able to configure the client underneath, through the engine block.

It should work with ChrisKruegerDev/tmdb-kotlin#27 like so (although I haven't tested it):

val tmdb = Tmdb3(apiKey) {
    engine {
        if (this is OkHttpConfig) {
            //  okhttp stuff
        } else ...
    }
}

[ChrisKruegerDev]

Yes, this should work 👍 It feels a bit risky to rely on the selected engine from the current source set. Ktor looks for the first engine:

public actual fun HttpClient(
    block: HttpClientConfig<*>.() -> Unit
): HttpClient = engines.firstOrNull()?.let { HttpClient(it, block) } 

I added the following config ChrisKruegerDev/tmdb-kotlin#28. I haven't tested the code, but it should work:

val tmdb = Tmdb3 {
            httpClient(OkHttp) {
               engine {
                    // for own client
               }
            }

            httpClient {
                // for custom config
            }
        }