This repository has been archived by the owner on Nov 12, 2024. It is now read-only.
Build and publish QA 'flavour' of iOS app #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
force-pushed
the
cb/ios-flavor
branch
from
51b831a to
1226a15
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the iOS app to have 3 'flavours':
Debug,QAandProdwhich match the Android app.Since most of the code is in the shared KMP module, we needed a way to create flavours of the shared module. Since the KMP Gradle module doesn't support flavors/variants like AGP, we instead split
:sharedinto:shared:common(common across flavours),:shared:qaand:shared:prod. The Android app module and iOS build phase then chooses which one it uses based on whatever app is being built.