This repository has been archived by the owner on Nov 12, 2024. It is now read-only.
Update to Compose snapshot #6342451 #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It shouldn't be clickable if the text hasn't overflowed.
andkulikov
approved these changes
Mar 30, 2020
| } else { | ||
| Box(modifier = modifier) | ||
| Box(modifier = modifier.onPositioned { childSize = it.size }) |
There was a problem hiding this comment.
could be nicer to do something like
var modifier = modifier.onPositioned { childSize = it.size }
if (image) {
...
modifier.paint(AndroidColorMatrixImagePainter(image, cf))
}
Box(modifier = modifier)
everytime you have if else blocks emitting different composables the previous Box should be completely disposed and the new Box recreated where in fact you can just update a modifier for the same Box
Thanks @andkulikov for the tip
Also managed to get rid of my dodgy onPositioned {}
logic with `Modifier.matchParent()`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.