This repository has been archived by the owner on Nov 12, 2024. It is now read-only.
Update to Compose + UI v0.1.0-dev12 #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,20 +16,7 @@ | |||
|
|
|||
| package app.tivi.common.compose | |||
|
|
|||
| import androidx.compose.Composable | |||
| import androidx.compose.Providers | |||
| import androidx.compose.staticAmbientOf | |||
| import app.tivi.util.TiviDateFormatter | |||
|
|
|||
| val TiviDateFormatterAmbient = staticAmbientOf<TiviDateFormatter>() | |||
There was a problem hiding this comment.
a whole file for an ambient? Consider creating a ProvideDateFormatter here similar to insets and renaming the file.
There was a problem hiding this comment.
From what I've seen from Adam, we shouldn't hide the APIs around ambients too much. ProvideInsets is a bit special because it needs to observe a LiveData, so wrapping it up makes sense to me. TiviDateFormatterAmbient is a very simple static ambient though.
nickbutcher
reviewed
May 28, 2020
ui-showdetails-view/src/main/java/app/tivi/showdetails/details/view/ShowDetails.kt
Outdated
Show resolved
Hide resolved
nickbutcher
approved these changes
May 28, 2020
ui-showdetails-view/src/main/java/app/tivi/showdetails/details/view/ShowDetails.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.