This repository has been archived by the owner on Nov 12, 2024. It is now read-only.
Lots of improvements around Coroutines usage #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated to Coroutines 1.3.7 - Replaced all usage of ConflatedBroadcastChannel with StateFlow - Started consuming `action` Channels via consumeAsFlow() to ensure the channels get closed. - Started checking for closed channels before `offer()`ing - Tidied up some of the internals of ReduxViewModel since we can now rely on `StateFlow`
|
/cc @manuelvicnt as he might be interested. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConflatedBroadcastChannelwithStateFlowpendingActionChannels in ViewModels viaconsumeAsFlow()to ensure the channels get closed.offer()ingReduxViewModelsince we can now rely onStateFlowStore's explicitCoroutineScope