This repository has been archived by the owner on Nov 12, 2024. It is now read-only.
Add implementation of absolute elevation #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important for show details, because it uses nested surfaces which are each elevated.
chrisbanes
force-pushed
the
cb/absolute-elevation
branch
from
99f4ec6 to
e224a84
Compare
nickbutcher
reviewed
Oct 21, 2020
common-ui-compose/src/main/java/app/tivi/common/compose/Elevation.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Oct 21, 2020
common-ui-compose/src/main/java/app/tivi/common/compose/Elevation.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Oct 21, 2020
…ion.kt Co-authored-by: Nick Butcher <nickbutcher@users.noreply.github.com>
nickbutcher
approved these changes
Oct 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important for show details, because it uses nested surfaces which are each elevated.
Tracking feature request for Compose: https://issuetracker.google.com/171031040