Skip to content
This repository has been archived by the owner on Nov 12, 2024. It is now read-only.

Some small performance improvements and bug fixes #741

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Conversation

chrisbanes
Copy link
Owner

@chrisbanes chrisbanes commented Dec 1, 2020

  • Removed our asyncOrAwat() functionality. It's no longer needed now that we're using Store with its multiplexer.
  • Fixed the loading counter not removing the loader when the coroutine is cancelled.
  • Fixed a crash caused by not filtering for Store's loading state.
  • Update Store to 4.0.0

@@ -28,3 +31,7 @@ suspend inline fun <Key : Any, Output : Any> Store<Key, Output>.fetch(
forceFresh -> fresh(key)
else -> get(key)
}

fun <T> Flow<StoreResponse<T>>.filterForResult(): Flow<StoreResponse<T>> = filterNot {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks useful, free internet points if you want to add to StoreResponse

@chrisbanes chrisbanes merged commit 93a2398 into main Dec 2, 2020
@chrisbanes chrisbanes deleted the cb/performance branch December 2, 2020 07:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants