Skip to content
This repository has been archived by the owner on Nov 12, 2024. It is now read-only.

Fix TraktAuthModule compile error #748

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Fix TraktAuthModule compile error #748

merged 1 commit into from
Jan 17, 2021

Conversation

alishari
Copy link

As I have described the problem #747, there was a problem in compiling code. current code called AuthorizationServiceConfiguration with three parameters but it has constructors with two or four parameters.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@alishari
Copy link
Author

CI task failed due to an error in uploading Crashlytics mapping which is not related to this commint:

Execution failed for task ':app:uploadCrashlyticsMappingFileRelease'.
> java.io.IOException: Unknown error while sending file, check network [/home/runner/work/tivi/tivi/app/build/crashlytics/Release/mappings/b7c898f0f8834136ab107d140cd48513.gz; response: 400 HTTP/1.1 400 Bad Request]

@chrisbanes chrisbanes merged commit c775841 into chrisbanes:main Jan 17, 2021
@chrisbanes
Copy link
Owner

Thanks for the PR! Looks like openid/AppAuth-Android#525 caused an API break. I've pinned our AppAuth dependency to a specific revision (ea4dc20) so we don't hit this in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants