This repository has been archived by the owner on Nov 12, 2024. It is now read-only.
Update to Dagger/Hilt 2.31.2 #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
force-pushed
the
cb/hilt-2.31.2
branch
from
98d93c5 to
fa02ea0
Compare
manuelvicnt
reviewed
Feb 2, 2021
chrisbanes
force-pushed
the
cb/hilt-2.31.2
branch
from
fa02ea0 to
02db233
Compare
manuelvicnt
approved these changes
Feb 3, 2021
The move to @HiltViewModel meant that we could no longer use an @ActivtyScoped dependency from a VM. Took the opportunity to use the new ActivityResult APIs
chrisbanes
force-pushed
the
cb/hilt-2.31.2
branch
from
ad559cd to
d7c1c6d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifact
androidx.hilt:hilt-lifecycle-viewmodelis no longer needed as Hilt v2.31 already contains code to generate ViewModels using the@HiltViewModelannotation.Artifact
com.squareup.inject:assisted-inject-annotations-dagger2is no longer needed as Hilt v2.31 adds assisted injection functionality.