Skip to content

Commit

Permalink
sentry: Disable Sentry for now on Android
Browse files Browse the repository at this point in the history
This is a workaround for zulip#5757, the crashes we've started to
regularly see as many users' devices have started taking the
Google Play system update dated 2023-08.

See the (long) chat thread here:
  https://chat.zulip.org/#narrow/stream/48-mobile/topic/Android.20crashes/near/1640893

and issue threads reported in Android's and Sentry's trackers:
  https://issuetracker.google.com/issues/300840851
  https://github.com/getsentry/sentry-unity/issues/1444

Our issue for re-enabling Sentry on Android is zulip#5766.

This commit was cherry-picked from 29cea89, part of v27.213,
with tweaks to mention zulip#5766.
  • Loading branch information
gnprice authored and chrisbobbe committed Sep 26, 2023
1 parent 3e84405 commit e8c57e7
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 8 deletions.
11 changes: 11 additions & 0 deletions docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,17 @@ It doesn't include

## Unreleased

### Highlights for users

* (Android) Disabled Sentry error reporting, which was causing
crashes following a recent Android update. (#5757)


### Highlights for developers

* Disabled Sentry on Android, as a workaround for the newly-frequent
crash bug #5757.


## 27.212 (2023-09-15)

Expand Down
9 changes: 3 additions & 6 deletions docs/howto/release.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,9 @@ simple terminology for the process we follow with both.
tools/checkout-keystore
```

* Apply the Sentry client key (using the local branch created for this
in initial setup):

```
git rebase @ release-secrets
```
* Do *not* apply the Sentry client key from the `release-secrets`
branch; if you're already on that branch (from e.g. making the iOS
build), move off of it. See our issues #5757 and #5766.

* Build the app, as both good old-fashioned APKs and a fancy new AAB:

Expand Down
6 changes: 4 additions & 2 deletions tools/android
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ do_apk() {
check_yarn_link
run_visibly yarn

run_visibly tools/gradle :app:assembleRelease -Psigned -Psentry
# TODO(#5766): start passing -Psentry again
run_visibly tools/gradle :app:assembleRelease -Psigned
}

do_aab() {
check_yarn_link
run_visibly yarn

run_visibly tools/gradle :app:bundleRelease -Psigned -Psentry
# TODO(#5766): start passing -Psentry again
run_visibly tools/gradle :app:bundleRelease -Psigned
}

case "${action}" in
Expand Down

0 comments on commit e8c57e7

Please sign in to comment.