Skip to content

Commit

Permalink
android: Prevent activity recreation on theme change.
Browse files Browse the repository at this point in the history
Part of the RN v0.61 -> v0.62 changes to the template app [1],
corresponding to facebook/react-native@83a16b16c. This is a bugfix
that we're free to do at any time as long as we don't have any code
that depends on the "UI mode" but neglects to listen for changes to
it. We don't currently need use the UI mode at all, and we won't
consider it until zulip#4009, for which the API isn't available until the
upcoming RN v0.62 upgrade.

See more detail from Greg on GitHub [2].

[1] https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.2
[2] zulip#4244 (comment)
  • Loading branch information
chrisbobbe authored and gnprice committed Sep 11, 2020
1 parent d179e90 commit f31b257
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
android:theme="@style/AppTheme">
<activity
android:name=".MainActivity"
android:configChanges="keyboard|keyboardHidden|orientation|screenSize"
android:configChanges="keyboard|keyboardHidden|orientation|screenSize|uiMode"
android:label="@string/app_name"
android:launchMode="singleTask"
android:windowSoftInputMode="adjustResize">
Expand Down

0 comments on commit f31b257

Please sign in to comment.