forked from zulip/zulip-mobile
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
android/deps: compileSdkVersion to 33 (Android 13); image-picker to 4…
….10.2 Seems like react-native-image-picker made it *possible* to build on the new SDK in the same commit where they made it *necessary* to do so, which was a bad choice: zulip#5543 (comment) So, shove the sdk bump and this image-picker upgrade together into one commit. Anyway, as Greg said in his draft of the compileSdkVersion bump, f5c90ec: This version is out; time to start using it in the build. This setting is not to be confused with the targetSdkVersion. The latter goes into the built manifest, and affects a wide range of behavior, so bumping it requires careful testing. This is used purely at build time, and should have no effect on runtime behavior. Its main effect is that it become possible for code to conditionally use new API features. It also brings new compiler warnings -- hence the pair of library updates preceding this. We take the latest image-picker version, but in particular at least 4.10.1, to get a bugfix for an image-orientation issue: react-native-image-picker/react-native-image-picker#2036 that was reportedly introduced in 4.8.5: react-native-image-picker/react-native-image-picker#2022
- Loading branch information
1 parent
07eebd7
commit fc2dab7
Showing
7 changed files
with
42 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 4 additions & 9 deletions
13
types/react-native-image-picker/lib/typescript/index.js.flow
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,14 @@ | ||
| /* @flow | ||
| * @generated by TsFlower | ||
| */ | ||
| import { | ||
| type CameraOptions, | ||
| type ImageLibraryOptions, | ||
| type Callback, | ||
| type ImagePickerResponse, | ||
| } from './types'; | ||
|
|
||
| import type { ImagePickerResponse as $tsflower_import_type$_$_2e__2f_types$ImagePickerResponse } from './types'; | ||
| import { type CameraOptions, type ImageLibraryOptions, type Callback } from './types'; | ||
| export * from './types'; | ||
| declare export function launchCamera( | ||
| options: CameraOptions, | ||
| callback?: Callback, | ||
| ): Promise<ImagePickerResponse>; | ||
| ): Promise<$tsflower_import_type$_$_2e__2f_types$ImagePickerResponse>; | ||
| declare export function launchImageLibrary( | ||
| options: ImageLibraryOptions, | ||
| callback?: Callback, | ||
| ): Promise<ImagePickerResponse>; | ||
| ): Promise<$tsflower_import_type$_$_2e__2f_types$ImagePickerResponse>; |
18 changes: 18 additions & 0 deletions
18
types/react-native-image-picker/lib/typescript/platforms/native.js.flow
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* @flow | ||
| * @generated by TsFlower | ||
| */ | ||
| import { | ||
| type CameraOptions, | ||
| type ImageLibraryOptions, | ||
| type Callback, | ||
| type ImagePickerResponse, | ||
| } from '../types'; | ||
|
|
||
| declare export function camera( | ||
| options: CameraOptions, | ||
| callback?: Callback, | ||
| ): Promise<ImagePickerResponse>; | ||
| declare export function imageLibrary( | ||
| options: ImageLibraryOptions, | ||
| callback?: Callback, | ||
| ): Promise<ImagePickerResponse>; |
12 changes: 12 additions & 0 deletions
12
types/react-native-image-picker/lib/typescript/platforms/web.js.flow
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /* @flow | ||
| * @generated by TsFlower | ||
| */ | ||
| import { type ImageLibraryOptions, type Callback, type ImagePickerResponse } from '../types'; | ||
| declare export function camera( | ||
| options?: ImageLibraryOptions, | ||
| callback?: Callback, | ||
| ): Promise<ImagePickerResponse>; | ||
| declare export function imageLibrary( | ||
| options?: ImageLibraryOptions, | ||
| callback?: Callback, | ||
| ): Promise<ImagePickerResponse>; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters