forked from zulip/zulip-mobile
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MainTabs [nfc]: Prepare for and explain some FlowFixMes.
The next commit's message is quite long, so here's the motivation for the FlowFixMes. Importing `createBottomTabNavigator` from `react-navigation` is good because it means more type checking! Sadly, getting that to really work in all the ways we want won't be easy. To sum up, we could get *part* of the way there by making tweaks to our typed `connect` (and making sure those tweaks didn't break something or lose type-checking elsewhere!). But there's an additional hurdle in something that's not quite right in the `react-navigation` libdef. The same goes for `createMaterialTopTabNavigator`. Greg goes into more detail at the PR thread [1]. See also discussion [2]. [1]: zulip#4114 (comment) [2]: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/react-navigation.20types/near/878259
- Loading branch information
1 parent
1f2657d
commit fce0cea
Showing
2 changed files
with
11 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters