PHP7 compatibility: Avoid using 'e' modifier in preg_replace #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2016 01:25
…use preg_replace_callback instead
petrkotek
commented
Sep 21, 2016
| * @return string The HTML representation of the string. | ||
| */ | ||
| function fixSpaces($spaces='') | ||
| private function fixSpaces(array $matches) |
There was a problem hiding this comment.
this method is used only by the callback above, so it can be private
|
🙇 thanks |
This was referenced Sep 22, 2016
lazyfrosch
added a commit
to lazyfrosch/php-diff
that referenced
this pull request
May 9, 2018
It avoids breaking the callback when no spaces are to be counted. This is a fixup for 2900dd9 (chrisboulton#42)
lazyfrosch
added a commit
to lazyfrosch/php-diff
that referenced
this pull request
May 9, 2018
It avoids breaking the callback when no spaces are to be counted. This is a fixup for 2900dd9 (chrisboulton#42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already plenty of PRs trying to fix this: #32 #36, #39, and #41.
I liked the best solution from #41, however I decided to polish it a bit and add test coverage to demostrate that it still works the same.