Skip to content

Fix fatal error under php 8 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Fix fatal error under php 8 #58

merged 1 commit into from
Jun 17, 2022

Conversation

joec4i
Copy link
Contributor

@joec4i joec4i commented Jun 17, 2022

String offset access with curly braces is no longer allowed in php 8.

     Fatal error: Array and string offset access syntax with curly braces is    
     no longer supported in                                                     
     /home/circleci/project/vendor/chrisboulton/php-diff/lib/Diff/Renderer/Htm  
     l/Array.php on line 153   

ping @chrisboulton

@jfcherng
Copy link

jfcherng commented Jun 17, 2022

Consider a modern successor? #53 (comment)

I don't think @chrisboulton is still interested in maintaining this lib since the latest commit is in 2016.

@chrisboulton chrisboulton merged commit 5b4aaed into chrisboulton:master Jun 17, 2022
@joec4i joec4i deleted the php8 branch June 17, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants