Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracks: "Solve unavailable" in all cases #584

Closed
yenseo7009 opened this issue Jan 18, 2023 · 2 comments
Closed

Tracks: "Solve unavailable" in all cases #584

yenseo7009 opened this issue Jan 18, 2023 · 2 comments
Labels
bug Fails to work as advertised or fails to meet most people's expectations upstream Likely relevant to other platforms, should be discussed with Simon, see README.md

Comments

@yenseo7009
Copy link

Seeing the Solution doesn't work for tracks puzzle
@yenseo7009
Copy link
Author

yenseo7009 commented Jan 18, 2023 •
edited
Loading

Even in unsolved puzzle

@chrisboyle chrisboyle added upstream Likely relevant to other platforms, should be discussed with Simon, see README.md bug Fails to work as advertised or fails to meet most people's expectations labels Jan 18, 2023
@chrisboyle
Copy link
Owner

Thanks, I've reported this upstream and hope to produce a fix this evening.

@chrisboyle chrisboyle changed the title Solve unavailable in tracks puzzle Tracks: "Solve unavailable" in all cases Jan 18, 2023
chrisboyle added a commit that referenced this issue Feb 10, 2023
@chrisboyle @bjh21
Tracks: let solve make illegal moves
b5e02b0 
Not only does it set the outer edges to NOTRACK, but it may also overwrite
any mistakes the user has previously made elsewhere. Otherwise, the entire
solve is rejected ("Solve unavailable" error on Android) if the user has
made a single mistake, which is inconsistent with the other games.

This may be giving a free pass to corrupted moves that occur after a solve,
so this may still want tightening up in some way, but it's still limited to
squares within the grid, so I agree with Ben's assessment that this is
likely not to be exploitable.

Fixes #584

(cherry picked from Android port, commit
33bd14f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fails to work as advertised or fails to meet most people's expectations upstream Likely relevant to other platforms, should be discussed with Simon, see README.md
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisboyle @yenseo7009