read static files with filed instead of createReadStream #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny change reads static files with
filed
instead of withfs.createReadStream
so that they are sent with the correct mime-type (currently, an annoying mime-type warning shows up in chrome saying js files were interpreted as js but transferred as text/plain).There is a minor trade-off here: because of a bug in
filed
, the stream created by thefiled()
method never actually emits an 'end' event, which means that thelog()
function in beefy doesn't get triggered. IMHO this is better than that annoying mime-type warning. Also, mikeal is bound to fix this sooner or later (hopefully sooner).