Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #20, a check was made to prevent maliciously crafted input from resulting in
NaN
orInfinity
decoded values.The check only allows varints with bitlength <= 48 to be decoded.
This is strict, perhaps overly strict. It disallows this library to decode varint64, an extremely common usecase.
But this leads us to a difficult situation without a deeper and more invasive code change -- a tradeoff between allowing a useful range of input buffer lengths and ensuring correctness of all outputs:
#20, was written with the intent of 1.
Talking with other teams who use this library, it seems that 2. is the more practical, useful.
cc @vasco-santos
This PR keeps the core check of #20, but relaxes it to allow for varint64.