Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fluent-ui-react-native controls #114

Closed
wants to merge 3 commits into from
Closed

Use fluent-ui-react-native controls #114

wants to merge 3 commits into from

Conversation

chrisglein
Copy link
Owner

@chrisglein chrisglein commented Mar 31, 2023

General issues hit along the way:

Button

Upsides

  • Supports hover
  • Supports tooltips
  • Supports styling differences for default buttons vs. standard buttons.

Downsides

Link

Downsides

Icon

Not sure whether intended or not that I can't use on its own: microsoft/fluentui-react-native#935
May be interesting as a straightforward wrapper for Segoe MDL2 style icons, like XAML has.

Separator

Seems cool, haven't tried.

Text

I guess this would give me standardized text ramps? Haven't tried.

Checkbox

Would prefer to toggle switches in Settings, honestly. Should migrate to?
image

- Allows use of their Button type
- Required importing SVG (see microsoft/fluentui-react-native#2613)
- Which in turn requires importing the Win2D nuget
- Also required switching to classic runtime (see microsoft/fluentui-react-native#1891)
@chrisglein
Copy link
Owner Author

Worked around many of these by implementing my own ThemeProvider. When that's solid enough it should be upstreamed to the FURN repo.

@chrisglein
Copy link
Owner Author

Superseded by #116

@chrisglein chrisglein closed this Mar 14, 2024
@chrisglein chrisglein deleted the furn branch March 14, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant