Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing http.end() if deserializing JSON fails #70

Closed
niclask opened this issue Jan 18, 2022 · 0 comments · Fixed by #72
Closed

Missing http.end() if deserializing JSON fails #70

niclask opened this issue Jan 18, 2022 · 0 comments · Fixed by #72

Comments

@niclask
Copy link

niclask commented Jan 18, 2022

http.end() is never called if the JSON deserialization fails.

esp32FOTA/src/esp32fota.cpp

Line 342 in 6648c9d

return false;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call http.end() if deserializing JSON fails thorrak/esp32FOTA
1 participant
@niclask