Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Mac - App continues to run in the background #8

Closed
3 tasks
Lightsout565 opened this issue Jun 26, 2018 · 19 comments
Closed
3 tasks

Feature Request: Mac - App continues to run in the background #8

Lightsout565 opened this issue Jun 26, 2018 · 19 comments

Comments

@Lightsout565
Copy link

Lightsout565 commented Jun 26, 2018

Mac Requests:

  • Add Icon to Menu Bar; Have menu bar change number or highlight blue when a new message shows up (See Tweetbot as a prime example)

  • Prevent Cmd+Q from fully quitting the app, allowing you to get notifications for new messages still (Similar to Evernote Helper)

  • Cmd+W is broken; doesn't close the window.

@chrisknepper
Copy link
Owner

Thanks for reporting these! I think they are all do-able!

@mwjburton
Copy link

Cmd+H to hide the window would also be very useful. Thanks

@chrisknepper
Copy link
Owner

chrisknepper commented Jun 27, 2018

Hey @Lightsout565 , I have some questions about your requests for macOS:

  1. For "Add Icon to Menu Bar," do you mean an icon in the top-right of the system menu bar (as in the attached screenshot)?
  2. Most mac apps in my experience will fully quit with the Cmd+Q shortcut. I can definitely make it so the app remains open when the window is closed via the red button, but I want to be clear: you would also like the app to remain open (but have the window disappear) when Cmd+Q is pressed?
  3. @mwjburton , Would you both be fine with Cmd+W and Cmd+H having the same behavior of closing (hiding) the window, or would you like more specific behavior for each?
    screen shot 2018-06-27 at 9 07 47 am

@rjxeon
Copy link

rjxeon commented Jun 27, 2018

Hey @chrisknepper great app, just switched over to Android from iOS and this was missing having messages on my Mac.

I agree with @Lightsout565 regards the Application staying open once you have hit the red button, would be a nice feature so it stays in the dock and I can still get Notifications. Everything else seems to run perfect for me. If you need anything new testing give me a shout.

@chrisknepper
Copy link
Owner

@rjxeon Thanks for the kind words! I have the app staying open when the window closes locally, just need to test it some more. I should tentatively release an update enabling this tonight.

@rjxeon
Copy link

rjxeon commented Jun 27, 2018

@chrisknepper Great look forward to it!, any Chance of notification bubble counter on the dock icon? Hard to see if you missed a notification

@chrisknepper
Copy link
Owner

@rjxeon Yep, a bubble on the dock icon is coming tonight! The update will also enable Command+H as a shortcut to hide the app as requested by @mwjburton and in #16 .

@Lightsout565 , I would also like to continue improving keyboard shortcuts, but I'm not sure if Command+W is a common shortcut to close the window, nor if Command+Q should not entirely quit the app. Do you know of other macOS apps which behave that way? Just trying to get the best user experience for you all!

@Lightsout565
Copy link
Author

Lightsout565 commented Jun 28, 2018

@chrisknepper Cmd+W is the common user interaction for closing a window, without quitting the app entirely. Also, regarding your earlier post Cmd+H and Cmd+W are very different commands. Cmd+W closes the window and terminates any instance of the app window, where as Cmd+H hides the app window without destroying it. For example, say I have Spotify open and I'm on an artist page. When I press Cmd+H, it hides the window, but when I click the Spotify app icon in the dock I get the same window, in the same artist page I left it. If I Cmd+W that same window, the app is still running in the background but I have terminated and closed the app window. When I press the Spotify icon this time, it will load up a new Spotify window instance and take me to the homepage.

Some apps will have a setting in their preferences to override Cmd+Q. So when the app is running and a user presses Cmd+Q, it closes just the window without quitting the app. The user can still quit the app by right clicking the icon in the dock, or having an option in the menubar icon to quit the app. But this allows the app to stay open for incoming notifications. It's useful for apps that benefit from always being available (like Evernote Helper - see below)

Hope this helps, thanks again.

image

@kidbrax
Copy link

kidbrax commented Jun 28, 2018

regarding the cmd-Q to quit i think it should follow best practices and fully quit the app but provide a separate helper if you want to keep something running in the background. in other words, i wouldn't want to quit the app only to find out that hasn't really quit unless i explicitly hose that.

Ha, I just read the note above.

@Lightsout565
Copy link
Author

Lightsout565 commented Jun 28, 2018

I agree with @kidbrax. Cmd+Q to quit is best practice and should be the default. Maybe having it as an option in settings as you mention to keep the app running in the background for those of us that want the app open all the time for incoming notifications.

I've actually added Android Messages as a login item for my account ("Hide" checkbox checked), so it's pretty much always running on my machine.

image

Anything I can do to replicate the iMessage system of always having SMS come through to my computer at all times.

@rjxeon
Copy link

rjxeon commented Jun 28, 2018

@Lightsout565 I think most apps like Messages tend to be CMD + W is quit but keeps running in the background ( light still on in the dock ), and CMD + Q could then be a complete quit out of the app? Notification bubble is working great now though.

@kidbrax
Copy link

kidbrax commented Jun 28, 2018

@rjxeon on Mac, cmd-W means close the current window, not sure about other platforms.

@chrisknepper
Copy link
Owner

Alrighty, so it sounds like Cmd+W to close the window but keep running should definitely make it in. Looking at Google Chrome, Cmd+W closes the current window but Chrome is also a multi-window application whereas this one really isn't. In v0.1.0, I added Cmd+H as a shortcut to hide the window without quitting the application since it was requested.

As long as Electron lets me have 2 keyboard shortcuts (which they call "Accelerators") that do the same thing, I'm all for it! Thanks again for your feedback all!

@chrisknepper
Copy link
Owner

Also, would you all prefer that this new shortcut live under a new File menu or Window menu in the Mac menu bar? I've seen apps do it under both, but I believe File is more common. Either way it's a new top-level menu.
screen shot 2018-06-28 at 10 31 38 pm

@Lightsout565
Copy link
Author

Lightsout565 commented Jun 29, 2018 via email

@kidbrax
Copy link

kidbrax commented Jun 29, 2018

@chrisknepper for cmd-q and cmd-h it should live under the main application menu, "Android Messages" but cmd-w should be under the File menu I believe. Thanks for adding these in, it's a great app!

@kidbrax
Copy link

kidbrax commented Jun 29, 2018

Just downloaded v1 to try the cmd-h to hide. It doesn't seem to work correctly though. It hides the window but the app stays in front. It should hide the whole app and make the next app active.

@LastInLine
Copy link

@kidbrax is right, cmd-h hides the window but doesn't switch to the next app. Right now it's working kind of like cmd-m should except without the genie effect to the dock.

@chrisknepper I don't know if you ever got an answer to question 1 in comment 4 but yes, an icon there to show that it's running in the background would be ideal, along with some indicator of an unread message when one comes in.

@chrisknepper
Copy link
Owner

Everything in this should be covered by v0.3.0, with the exception of the "tray" icon highlighting when a notification comes in for macOS. I believe we should open another issue for that because the UX implications of that also apply to Windows and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants