forked from emberjs/rfcs
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: template imports #4
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, introduce a *first draft* of some of the RFC: - [x] Summary - [ ] Motivation - [-] Detailed Design - [-] How we teach this - [x] Alternatives - [x] Unresolved questions
chriskrycho
force-pushed
the
template-imports
branch
from
November 24, 2021 15:48
6196658
to
0fdfc1d
Compare
chriskrycho
force-pushed
the
template-imports
branch
from
November 24, 2021 16:11
5497840
to
94291b2
Compare
- swap order of example code vs benefits list - add note about assuming default modifier manager, and update the code to use that capability throughout
chriskrycho
force-pushed
the
template-imports
branch
from
December 3, 2021 01:22
fb26b16
to
67ef8bc
Compare
chriskrycho
force-pushed
the
template-imports
branch
from
December 3, 2021 16:37
0a9d3b9
to
e61a278
Compare
Opened as emberjs#779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rendered WIP text