Implementation of bright colors #27
Conversation
pygments_ansi_color/__init__.py
Outdated
| 'White': '#ffffff', | ||
| 'White': '#CFCFCF', | ||
| 'BrightBlack': '#676767', | ||
| 'BrightRed': '#FF6D67', | ||
| 'BrightGreen': '#5FF967', | ||
| 'BrightYellow': '#FEFB67', | ||
| 'BrightBlue': '#6871FF', | ||
| 'BrightMagenta': '#FF76FF', | ||
| 'BrightCyan': '#5FFDFF', | ||
| 'BrightWhite': '#FEFFFF', |
There was a problem hiding this comment.
Can you add a screenshot of what these new colors look like? I'd like to make sure they look consistent with the existing default colors.
Also, was changing white intentional?
There was a problem hiding this comment.
Bright colors:
These are loosely based on the color scheme used by iterm2.
Also, was changing white intentional?
Yes. If you have a bright white, the regular white cannot be as bright.
There was a problem hiding this comment.
I re-created the original testing image that I used for this repo with bright colors added:
(Rows 3, 6, 9 have bright FG colors; rows 7-9 have bright BG colors.)
The bright colors look good to me but I think the grayer white is a bit of a regression since white FG with colored background is a pretty common scenario and it is harder for me to read with some of the backgrounds (especially green and red).
How do you feel about #F5F5F5 for the default white? I think it looks OK, compare what you have in this PR (#CFCFCF):
vs my proposal (#F5F5F5):
The "bright" white is still a bit brighter. Not quite as noticeable but I think it's worth it for the readability?
Also if you still prefer the #CFCFCF color you could always set it in your application, I'm mostly just thinking about the default for this package.
There was a problem hiding this comment.
I have changed it to #f5f5f5 in 3dc65ca. I have no problems with changing the defaults for any of these colours, as they are only in comments and documentation anyway, and I'll override them (and the default colors as well) in the applications I'll use this in.
|
Released as v0.2.0, thanks! |
Resolves #8.