Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof INTERRUPT_LEAD_INS #597

Closed
wopian opened this issue Feb 20, 2020 · 4 comments · Fixed by #732
Closed

Proof INTERRUPT_LEAD_INS #597

wopian opened this issue Feb 20, 2020 · 4 comments · Fixed by #732
Assignees
Labels
Size: Tiny Under 250 lines
Milestone

Comments

@wopian
Copy link
Collaborator

wopian commented Feb 20, 2020

Proof read transcribed code of INTERRUPT_LEAD_INS against scans

Lines: 117
Page: 0153—0154 (2)

Reduced quality scans can be found here

@wopian wopian added Help Wanted Size: Small 250 to 499 lines labels Feb 20, 2020
@wopian wopian added this to the Luminary099 milestone Feb 20, 2020
@wopian wopian added Size: Tiny Under 250 lines and removed Size: Small 250 to 499 lines labels Feb 20, 2020
@Nabeelhassan
Copy link
Contributor

I am taking this task. Will create a pull request shortly.

Nabeelhassan pushed a commit to Nabeelhassan/Apollo-11 that referenced this issue Oct 8, 2020
@wopian wopian linked a pull request Oct 8, 2020 that will close this issue
@Nabeelhassan
Copy link
Contributor

why did you remove the hacktoberfest label @wopian ???

@wopian
Copy link
Collaborator Author

wopian commented Oct 8, 2020

why did you remove the hacktoberfest label @wopian ???

Because it's a tag temporarily added alongside Good First Issue (on issues with Help Wanted and either Tiny or Small labels).

These labels are there to guide potential contributors to issues they will manage to complete, instead of going in blind to a huge or bigger issue with 40+ pages and getting overwhelmed. The two biggest size labels are not something that can be reasonably proofed and reviewed within a month and do not have Good First Issue or hacktoberfest labels.

This issue now has a PR that proofs it and no longer needs the Helped Wanted label, which makes the Good First Issue and hacktoberfest labels unneeded.

The hacktoberfest label has no effect on Hacktoberfest eligibility. The repository has the hacktoberfest topic and all approved or merged PRs are eligble. The only labels Hactoberfest cares about are hacktoberfest-accepted (if the repository hasn't opted in), spam or invalid on PRs.

image

@Nabeelhassan
Copy link
Contributor

Ok, thanks for the clarification.

wopian pushed a commit that referenced this issue Oct 19, 2020
Co-authored-by: nabeel.hassan <nabeel.hassan@colwiz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: Tiny Under 250 lines
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants