Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof LEM_GEOMETRY #604 #725

Merged
merged 8 commits into from
Oct 24, 2020
Merged

Proof LEM_GEOMETRY #604 #725

merged 8 commits into from
Oct 24, 2020

Conversation

GintasS
Copy link
Contributor

@GintasS GintasS commented Oct 7, 2020 •
edited
Loading

Not sure about LINE 55 COUNT*

@github-actions github-actions bot added the Type: Proof Comanche55 and Luminary99 files label Oct 7, 2020
@GintasS GintasS mentioned this pull request Oct 7, 2020
Closed
@wopian wopian linked an issue Oct 7, 2020 that may be closed by this pull request
Proof LEM_GEOMETRY #604
Closed
@wopian wopian self-requested a review October 7, 2020 20:08
@wopian wopian self-assigned this Oct 7, 2020
@wopian wopian added this to the Luminary099 milestone Oct 7, 2020
wopian
wopian requested changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@wopian wopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment changes to the assembly code is incorrect - how the code was originally aligned is how it should be (see other files for columns). I've reverted this change only as far as page 320. Please revert the Assembly code alignment changes for pages 321-325.

image

@GintasS
Copy link
Contributor Author

GintasS commented Oct 20, 2020

The alignment changes to the assembly code is incorrect - how the code was originally aligned is how it should be (see other files for columns). I've reverted this change only as far as page 320. Please revert the Assembly code alignment changes for pages 321-325.

image

Fixed formatting.

@wopian
Copy link
Collaborator

wopian commented Oct 20, 2020 •
edited
Loading

Fixed formatting.

The indentation between the Assembly code columns (3 columns as pictured above) need to be with tab characters not spaces

Edit: Same with the gap between the last code column and the start of the comment section

image

@wopian wopian self-requested a review October 20, 2020 16:09
@wopian
Copy link
Collaborator

wopian commented Oct 24, 2020

Thank you for promptly applying the requested changes 👍

@wopian wopian merged commit 0c61368 into chrislgarry:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wopian wopian wopian approved these changes

Assignees

@wopian wopian

Labels
Type: Proof Comanche55 and Luminary99 files
Projects
None yet
Milestone
Luminary099
Development

Successfully merging this pull request may close these issues.

Proof LEM_GEOMETRY
2 participants
@GintasS @wopian