Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Story Mode - Setting audio offset desyncs Robot MODE #53

Closed
vinceiis opened this issue May 7, 2023 · 9 comments
Closed

[Bug]: Story Mode - Setting audio offset desyncs Robot MODE #53

vinceiis opened this issue May 7, 2023 · 9 comments
Assignees
Labels
Priority: High Status: Fixed The issue has been fixed for a future release, and will be closed manually by a maintainer Type: Bug Something isn't working

Comments

@vinceiis
Copy link

vinceiis commented May 7, 2023

Version

v2.0.1-20230506a

Operating System

Windows 10

Problem Description

Cues in the Robot MODE level occur at the wrong times after restarting the level if offset is negative.
Most things including sounds, cues, and music desync if offset is positive.

Steps to Reproduce Problem

For negative offset:

  1. Set audio offset below 0
  2. Start Robot MODE and wait until the opening scene finishes
  3. Restart the level in any way that skips the opening scene (Start Over in pause menu, Start Over after failure)

For positive offset:

  1. Set audio offset above 0
  2. Start Robot MODE

Relevant log output

No response

(Optional) Other useful information

No response

@vinceiis vinceiis added Priority: Triage Needs to be looked at by a maintainer before being assigned a priority Type: Bug Something isn't working labels May 7, 2023
@chrislo27 chrislo27 added the Status: Investigating The issue is actively being investigated label May 7, 2023
@chrislo27
Copy link
Owner

chrislo27 commented May 7, 2023

Thanks for the report. Can you please record an upload a video for the scenarios you described? I've tried running the two scenarios myself and it seems alright with either offset (pos/neg), at least audio-wise. With the positive case, the robot sounds for the dialogue are delayed but that seems to be expected.

@vinceiis
Copy link
Author

vinceiis commented May 8, 2023

@vinceiis
Copy link
Author

vinceiis commented May 8, 2023

After further testing, it seems like Endless mode (also Daily Challenge) slowly desyncs with every speedup as well

@chrislo27
Copy link
Owner

chrislo27 commented May 8, 2023

Thanks for the videos, they definitely illustrate the problem very well. I will look into a fix for this.

Out of curiosity, what offset settings were you using? I'm assuming they were pretty significant (more than +/- 300 ms)?

@chrislo27 chrislo27 self-assigned this May 8, 2023
@chrislo27 chrislo27 added Priority: High Status: In Progress The issue/enhancement is actively in progress and removed Priority: Triage Needs to be looked at by a maintainer before being assigned a priority Status: Investigating The issue is actively being investigated labels May 8, 2023
@vinceiis
Copy link
Author

vinceiis commented May 9, 2023

For video purposes to show the problem more clearly I used max settings (±500) but issues are still noticable at my usual offset of -190

@chrislo27
Copy link
Owner

I believe the negative audio issue (after starting over) only persists for a little while. The music seems to skip after a few measures but I think it's normal after that. Can you confirm this?

For the positive offset case, it's an issue with how the music auto-adjusts in case there was frame lag -- that will be fixed.

(And the robot SFX for the textboxes being offset will be changed too)

@vinceiis
Copy link
Author

vinceiis commented May 9, 2023

Yeah, negative offset fixes itself after the intro audio file is done playing (but it doesn't apply for the issue I encountered with Endless mode slowly desyncing)

@chrislo27
Copy link
Owner

chrislo27 commented May 10, 2023

I've resolved the issue regarding negative audio offsets and the boss. I will try to get a patch out soon-ish (this weekend at earliest depending on pre-releases etc). If you're interested in testing it out by building the game locally, the fix is in the master branch already.

As for the Endless Mode desync, I will not address it in this issue to keep it focused to the issue with the boss. Feel free to open another issue for that as it'll be easier to track and investigate.

Thanks for reporting! I will close this issue manually once the release with the fix is out.

@chrislo27 chrislo27 added Status: Fixed The issue has been fixed for a future release, and will be closed manually by a maintainer and removed Status: In Progress The issue/enhancement is actively in progress labels May 10, 2023
@chrislo27 chrislo27 added this to the Next Patch Version milestone May 10, 2023
@chrislo27
Copy link
Owner

Fix released with v2.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Status: Fixed The issue has been fixed for a future release, and will be closed manually by a maintainer Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants