Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move styles to addon tree #103

Merged
merged 2 commits into from
Apr 30, 2017
Merged

Move styles to addon tree #103

merged 2 commits into from
Apr 30, 2017

Conversation

chrislopresto
Copy link
Owner

No description provided.

Copy link
Collaborator

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good -- consider improving the commit message to include motivation.

Staying out of the app tree will allow Ember Freestyle to

- better support addon blacklisting https://github.com/ember-cli/ember-cli/blob/21a2e44619685d86327da1bb8b740e7a968f401a/lib/broccoli/ember-app.js
- take less of an opinion on the CSS pre/post processors of choice in consuming apps
@lukemelia
Copy link
Collaborator

More background on addon blacklisting for the curious: ember-cli/ember-cli#5107

This was referenced May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants