Add tests for freestyle dynamic

[danwenzel]

Adds acceptance tests and a property assertion/test for freestyle dynamic

[lukemelia]

@danwenzel I'm excited that you've followed up with tests for the freestyle-dynamic work. The following is just my opinion: I don't think page objects are a good fit for an opensource project. They essentially define a new DSL that you need to learn in order to understand the tests, which you can make a case for on a team that is living with an test suite for years, but is harder when you want new contributors to be able to pop into an open source repo and help. I would prefer to see freestyle adopt a qunit.dom-style approach to assertions. Again, just my $.02.

[danwenzel]

Good thoughts, @lukemelia . I was following the pattern of the existing acceptance tests, so perhaps @chrislopresto has some thoughts. If we're going to make a change, it's probably better to do it throughout the test suite to keep things consistent .

[chrislopresto]

Awesome. Thanks, @danwenzel!

@lukemelia It may indeed be nice to refactor the entire test suite away from page objects. I'd be happy to merge this PR as is to gain the test coverage in the meantime, though. Thoughts?

[danwenzel]

@lukemelia - What do you think? Ok to merge this, and then separately refactor tests later?

[danwenzel]

@chrislopresto - Luke seems to be unresponsive :) Shall we just merge this?

[lukemelia]

Whoops, sorry. I'm +1. Don't let the perfect be the enemy of the good!

[chrislopresto]

Thanks @danwenzel!