Render headings instead of divs #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
This looks good to me.
@lukemelia It seems the semantic pull request check doesn't run anymore. Can you mention what needs to be done to make sure this commit / PR ends up in the changelog?
KamiKillertO
force-pushed
the
render-headings
branch
from
219d8ef to
75ffdf7
Compare
|
I've renamed the commits to match the expected format 👍 |
It's been a while. It looks like we have a release script that runs |
lukemelia
approved these changes
Sep 9, 2022
|
Released as 0.15.0. Thanks @KamiKillertO! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the addon renders a bunch of divs instead of heading tags.
This is an accessibility issue.
Also I think it could be a good idea to render links with anchor inside each title. What do think?