replaces hard-coded UI text with language keys for english and spanish

chrismaltby · Oct 5, 2024 · 3237f33 · 3237f33
1 parent 7a59195
commit 3237f33
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/src/components/pages/SettingsPage.tsx b/src/components/pages/SettingsPage.tsx
@@ -370,10 +370,10 @@ const SettingsPage: FC = () => {
             <>
               <SearchableSettingRow
                 searchTerm={searchTerm}
-                searchMatches={["DMG Background Palette (BGP)"]}//TODO: l10n language lookup -NB
+                searchMatches={[l10n("FIELD_DEFAULT_DMG_BGP")]}
               >
                 <SettingRowLabel>
-                  {"DMG Background Palette (BGP)"}
+                  {l10n("FIELD_DEFAULT_DMG_BGP")}
                 </SettingRowLabel>
                 <SettingRowInput>
                   <DMGPalettePicker 
@@ -386,10 +386,10 @@ const SettingsPage: FC = () => {
               </SearchableSettingRow>
               <SearchableSettingRow
                 searchTerm={searchTerm}
-                searchMatches={["DMG Object Palette 0 (OBP0)"]}
+                searchMatches={[l10n("FIELD_DEFAULT_DMG_OBP0")]}
               >
                 <SettingRowLabel>
-                  {"DMG Object Palette 0 (OBP0)"}
+                  {l10n("FIELD_DEFAULT_DMG_OBP0")}
                 </SettingRowLabel>
                 <SettingRowInput>
                   <DMGPalettePicker 
@@ -402,10 +402,10 @@ const SettingsPage: FC = () => {
               </SearchableSettingRow>
               <SearchableSettingRow
                 searchTerm={searchTerm}
-                searchMatches={["DMG Object Palette 1 (OBP1)"]}
+                searchMatches={[l10n("FIELD_DEFAULT_DMG_OBP1")]}
               >
                 <SettingRowLabel>
-                  {"DMG Object Palette 1 (OBP1)"}
+                  {l10n("FIELD_DEFAULT_DMG_OBP1")}
                 </SettingRowLabel>
                 <SettingRowInput>
                   <DMGPalettePicker 

diff --git a/src/lang/en.json b/src/lang/en.json
@@ -593,6 +593,9 @@
   "FIELD_COLLISION_LADDER": "Ladder",
   "FIELD_RESET_PALETTE": "Reset Palette",
   "FIELD_REMOVE_PALETTE": "Remove Palette",
+  "FIELD_DEFAULT_DMG_BGP": "DMG Background Palette (BGP)",
+  "FIELD_DEFAULT_DMG_OBP0": "DMG Sprite Palette 0 (OBP0)",
+  "FIELD_DEFAULT_DMG_OBP1": "DMG Sprite Palette 1 (OBP1)",
   "FIELD_DEFAULT_BACKGROUND_PALETTES": "Default Background Palettes",
   "FIELD_DEFAULT_SPRITE_PALETTES": "Default Sprite Palettes",
   "FIELD_CUSTOM_HTML_HEADER": "Custom HTML Header",

diff --git a/src/lang/es.json b/src/lang/es.json
@@ -588,6 +588,9 @@
   "FIELD_COLLISION_LADDER": "Escalera",
   "FIELD_RESET_PALETTE": "Restablecer paleta",
   "FIELD_REMOVE_PALETTE": "Eliminar paleta",
+  "FIELD_DEFAULT_DMG_BGP": "Paletas de Fondo Monocromática (BGP)",
+  "FIELD_DEFAULT_DMG_OBP0": "Paleta de Sprites Monocromáticos 0 (OBP0)",
+  "FIELD_DEFAULT_DMG_OBP1": "Paleta de Sprites Monocromáticos 1 (OBP1)",
   "FIELD_DEFAULT_BACKGROUND_PALETTES": "Paletas de fondo predeterminadas",
   "FIELD_DEFAULT_SPRITE_PALETTES": "Paletas de Sprites predeterminadas",
   "FIELD_CUSTOM_HTML_HEADER": "Encabezado HTML personalizado",