Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/manage tile alloc #1505

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Mico27
Copy link
Contributor

@Mico27 Mico27 commented Aug 13, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature: Allows the user to specify the tile allocation style for a background.

By default both options are checked and is the same behaviour as GBS 4 which reserve tiles for its default ui and allocate BG tiles upwards in the shared tileset VRAM to prioritise sprite tile overflowing in it.

Unchecking both options "Prioritize Sprite Allocation" and "Reserve UI Tiles" will have the same behaviour as GBS 3.

  • What is the current behavior? (You can also link to an open issue here)
    Current behavior forces a certain tile allocation, making it hard to have control over the tileset VRAM

  • What is the new behavior (if this is a feature change)?
    2 checkboxes are added under the background selection in a scene allowing to change tile allocation behavior.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No breaking changes should occur as the tile allocation will be the same as GBS 4 was by default.

  • Other information:
    Some screenshots
    image
    image

For people who have some scenes that have more than 192 unique tiles (up to 256 in normal mode and up to 512 in color-only mode) and dont use the default ui system.
issues fixed:
- The background image compiler would cap at 192 unique tile, not allowing any way to have more tiles even with a plugin fix
- Removed ALLOC_BKG_TILES_TOWARDS_SPR definition in the engine as the new allocation hard caps at 192 tiles
…ackground.

By default its the same behaviour as GBS 4 which reserve tiles for its default ui and allocate BG tiles upwards in the shared tileset VRAM to prioritise sprite tile overflowing in it.

Unchecking both options "Prioritize Sprite Allocation" and "Reserve UI Tiles" will have the same behaviour as GBS 3.
# Conflicts:
#	src/lib/compiler/compileImages.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant