Merge pull request #242 from easyrider/master

Fix: Form.validationErrors disables input validation #239
christianalfoni · Nov 3, 2015 · cfebf17 · cfebf17
2 parents 300a53f + 8cf8409
commit cfebf17
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/main.js b/src/main.js
@@ -83,7 +83,7 @@ Formsy.Form = React.createClass({
 
   componentDidUpdate: function () {
 
-    if (this.props.validationErrors) {
+    if (this.props.validationErrors && typeof this.props.validationErrors === 'object' && Object.keys(this.props.validationErrors).length > 0) {
       this.setInputValidationErrors(this.props.validationErrors);
     }
 

diff --git a/tests/Element-spec.js b/tests/Element-spec.js
@@ -295,6 +295,29 @@ export default {
 
   },
 
+  'should not override error messages with error messages passed by form if passed eror messages is an empty object': function (test) {
+
+    const TestForm = React.createClass({
+      render() {
+        return (
+          <Formsy.Form validationErrors={{}}>
+            <TestInput name="A" validations={{
+              isEmail: true
+            }} validationError="bar2" validationErrors={{isEmail: 'bar3'}} value="foo"/>
+          </Formsy.Form>
+        );
+      }
+    });
+    const form = TestUtils.renderIntoDocument(<TestForm/>);
+
+    const inputComponent = TestUtils.findRenderedComponentWithType(form, TestInput);
+    test.equal(inputComponent.getErrorMessage(), 'bar3');
+
+    test.done();
+
+  },
+
+
   'should override all error messages with error messages passed by form': function (test) {
 
     const TestForm = React.createClass({