Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple rendering with PureRenderMixin #252

Merged
merged 1 commit into from
Nov 5, 2015
Merged

Prevent multiple rendering with PureRenderMixin #252

merged 1 commit into from
Nov 5, 2015

Conversation

gregberge
Copy link
Contributor

Creating a new instance of error triggers two additional rendering when typing in an input, using same instance prevent it to happen.

Creating a new instance of error triggers two additional rendering when typing in an input, using same instance prevent it to happen.
@gregberge
Copy link
Contributor Author

@christianalfoni do you intend to merge it? Also can you make a release after? Thanks 👍

@Semigradsky
Copy link
Collaborator

@neoziro Hi! Could you add a test for this case?

@gregberge
Copy link
Contributor Author

@Semigradsky for multiple rendering I don't see how to write the test :/

@Semigradsky
Copy link
Collaborator

@neoziro ok, could you show this in http://codepen.io/semigradsky/pen/dYYpwv?editors=001 ? Just fork this pen and edit it.

@gregberge
Copy link
Contributor Author

@Semigradsky you can see 3 render in the console http://codepen.io/anon/pen/EVpEpd?editors=001
With my modification, you will see only one.

Semigradsky added a commit that referenced this pull request Nov 5, 2015
Prevent multiple rendering with PureRenderMixin
@Semigradsky Semigradsky merged commit f67f831 into christianalfoni:master Nov 5, 2015
@Semigradsky
Copy link
Collaborator

Nice! I added test 59bde83 and merged it

@gregberge
Copy link
Contributor Author

@Semigradsky thanks, can you release it?

@Semigradsky
Copy link
Collaborator

Nope. @christianalfoni ?

@avetisk
Copy link

avetisk commented Apr 12, 2016

@christianalfoni: could you transfer the ownership of this project if you're not maintaining it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants