-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent multiple rendering with PureRenderMixin #252
Conversation
Creating a new instance of error triggers two additional rendering when typing in an input, using same instance prevent it to happen.
@christianalfoni do you intend to merge it? Also can you make a release after? Thanks 👍 |
@neoziro Hi! Could you add a test for this case? |
@Semigradsky for multiple rendering I don't see how to write the test :/ |
@neoziro ok, could you show this in http://codepen.io/semigradsky/pen/dYYpwv?editors=001 ? Just fork this pen and edit it. |
@Semigradsky you can see 3 render in the console http://codepen.io/anon/pen/EVpEpd?editors=001 |
Prevent multiple rendering with PureRenderMixin
Nice! I added test 59bde83 and merged it |
@Semigradsky thanks, can you release it? |
Nope. @christianalfoni ? |
@christianalfoni: could you transfer the ownership of this project if you're not maintaining it anymore. |
Creating a new instance of error triggers two additional rendering when typing in an input, using same instance prevent it to happen.