Upgrade Asciidoctor JS to 2.0.3, MathJaX to 2.7.6, HighlightJS to 9.16.2 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 12, 2019
src/main/resources/static/lib/asciidoctor/asciidoctor-wrapper.js
Outdated
Show resolved
Hide resolved
src/main/resources/static/asciidoc-renderer/asciidoc-renderer.js
Outdated
Show resolved
Hide resolved
Run the server `atlas-mvn bitbucket:run`, then later on perform `atlas-mvn package`.
Note that since the atlassian sdk is using YUI to compress javascript files, it doesn't work with modern JS and fails to compress asciidoctor.js, so the compression is disabled in the maven plugin, to work around it the plugin uses the minified version that shipped with the original library.
Switching to new CDN as the previous one was decommissioned. See https://www.mathjax.org/cdn-shutting-down/
POST https://highlightjs.org/download/ cookie: csrftoken=b5dklwK2x6n9MNBrR3JkuFuHyTtwbxMCD3FiPpQH3JBTySuPGp6j7iPsPTTwRoIz csrfmiddlewaretoken=bLkk736HlhD5KtZKsxUmEAdFBuaRteM6DJMiBWcmRURPwyS8hThlhdyqSuAR95I3&apache.js=on&bash.js=on&cs.js=on&cpp.js=on&css.js=on&coffeescript.js=on&diff.js=on&go.js=on&xml.js=on&http.js=on&json.js=on&java.js=on&javascript.js=on&kotlin.js=on&less.js=on&lua.js=on&makefile.js=on&markdown.js=on&nginx.js=on&objectivec.js=on&php.js=on&perl.js=on&properties.js=on&python.js=on&ruby.js=on&rust.js=on&scss.js=on&sql.js=on&shell.js=on&swift.js=on&ini.js=on&typescript.js=on&yaml.js=on&plaintext.js=on&accesslog.js=on&ada.js=on&asciidoc.js=on&aspectj.js=on&abnf.js=on&bnf.js=on&cmake.js=on&clojure.js=on&dns.js=on&dart.js=on&dockerfile.js=on&elm.js=on&erlang.js=on&ebnf.js=on&golo.js=on&gradle.js=on&groovy.js=on&haskell.js=on&matlab.js=on&pgsql.js=on&powershell.js=on&protobuf.js=on&r.js=on&scala.js=on&tcl.js=on&thrift.js=on&vim.js=on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the bitbucket 6 support done in adds-bitbucket-6-support branch e.g. after #29.
The aim of this PR is to upgrade the component that allows to render asciidoc documents.
Note that since the atlassian sdk is using YUI to compress javascript files, it doesn't work with modern JS and fails to compress asciidoctor.js, so the compression is disabled in the maven plugin, but the commits uses the minified versions that shipped with the original components libraries.
Note that to deploy the plugin using the atlassian sdk I had to use a final version not a snapshot one. I don't know how to bypass that.