Improve local smoke tests and introduce dev containers support #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Refit.HttpClientFactory package was updated from version 6.3.2 to version 7.0.0 in MinimalApi.csproj. This was done to leverage the improvements and bug fixes in the latest version of the library.
This commit addresses the redundant configuration that was spread across all .csproj files for each target framework. Common settings such as OutputType, LangVersion, shared source files, and package references have been consolidated into a Directory.Build.props file, which automatically applies these settings to all projects in the directory. Also, Refit has been upgraded from version 6.3.2 to version 7.0.0. This approach will reduce maintenance overhead, ensure consistency across projects, and simplify potential future upgrades.
A new line was added to the PropertyGroup section of the Directory.Build.props file in the ConsoleApp project, specifically setting the EmitCompilerGeneratedFiles property to true. This change will allow the compiler to output additional files that are useful for debugging and understanding how the compiler interprets the code.
…d build one spec at a time A new function, GenerateAndBuild, was added to eliminate repetitive code blocks in the script, improving readability and maintainability. This function handles the generation and building of output paths for different formats and namespaces. The modifications also include treating warnings as errors in the build process to ensure high code quality.
An await Task.Delay(0) statement was added to the main method in Program.cs. This is to ensure proper asynchronous execution of the method, preventing potential deadlocks or delays in the future, improving performance and stability. Task.Delay(0) means 'yield' and allows other tasks to execute.
This change introduces a `-p:TreatWarningsAsErrors=true` flag to the `dotnet build` command in various .NET project's GitHub workflows. The goal is to enforce a higher code quality by turning all warnings into errors, thus causing the build to fail if any warnings occur. This will help catch potential issues earlier, improving the stability and reliability of the codebase.
This reverts commit 740a211.
The paths-ignore section of the smoke tests workflow in GitHub Actions has been updated to only ignore changes outside the 'src' directory. Previously, these tests were being triggered for any changes to .cs and .csproj files anywhere in the repo. This change ensures smoke tests run only when relevant source code is modified.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 32 32
Lines 997 997
=======================================
Hits 980 980
Misses 6 6
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.