Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Action<IHttpClientBuilder>? parameter in ConfigureRefitClients #215

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

Noblix
Copy link
Contributor

@Noblix Noblix commented Nov 7, 2023

This allows for passing in a parameter of type Action<IHttpClientBuilder> when configuring the Refit client. This can be useful in scenarios where the consumer wants to modify the IHttpClientBuilder.

Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #215 (60bf68e) into main (ce1123a) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          55       55           
  Lines        2002     2006    +4     
=======================================
+ Hits         1968     1972    +4     
  Misses         17       17           
  Partials       17       17           
Flag Coverage Δ
unittests 98.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Refitter.Core/DependencyInjectionGenerator.cs 100.00% <100.00%> (ø)

@christianhelle christianhelle self-assigned this Nov 7, 2023
@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Nov 7, 2023
Copy link
Owner

@christianhelle christianhelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Noblix Thanks for your contribution. This looks really good to me!

@christianhelle christianhelle merged commit 80a2eed into christianhelle:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants