Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added InterfaceName to avoid counting in operation names #223

Conversation

edimarquez
Copy link

Added InterfaceName to avoid counting in operation names with parameter "multipleInterfaces". This solves a problem on apis with many tags with same operations.

…er "multipleInterfaces". This solves a problem on apis with many tags with same operations.
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e02aee0) 98.30% compared to head (f40ef16) 98.14%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Refitter.Core/IdentifierUtils.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   98.30%   98.14%   -0.16%     
==========================================
  Files          55       55              
  Lines        2006     1888     -118     
==========================================
- Hits         1972     1853     -119     
- Misses         17       18       +1     
  Partials       17       17              
Flag Coverage Δ
unittests 98.14% <85.71%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle
Copy link
Owner

@edimarquez Thanks for taking the time to implement this.

Although having multiple tags on an endpoint is valid based on the OpenAPI spec schema, I have never seen any OpenAPI spec document that has more than 1 tag per endpoint.

I personally only use the tags so that Swagger UI can group my endpoints by category, something like this:

image

@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Nov 20, 2023
@christianhelle christianhelle self-assigned this Nov 20, 2023
@edimarquez
Copy link
Author

@christianhelle welcome!

Here is my scenario:

image

And the generated code:
image

When introducing a new group of endpoints, the methods are reenumerated and the code breaks.

@christianhelle christianhelle merged commit ceda5dc into christianhelle:main Nov 20, 2023
423 of 425 checks passed
@christianhelle
Copy link
Owner

@all-contributors please add @edimarquez for code

Copy link
Contributor

@christianhelle

I've put up a pull request to add @edimarquez! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants