Ensure Task<ApiResponse> is Returned for Void Methods in Generator #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated logic to wrap void return types in `Task<ApiResponse>` when `settings.ReturnIApiResponse` is true.
|
Kudos, SonarCloud Quality Gate passed!
|
christianhelle
added
bug
|
@all-contributors please add @mortenlaursen for code |
|
I've put up a pull request to add @mortenlaursen! 🎉 |
christianhelle
approved these changes
Dec 11, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 98.19% 98.22% +0.02%
==========================================
Files 56 57 +1
Lines 1939 1969 +30
==========================================
+ Hits 1904 1934 +30
Misses 18 18
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@mortenlaursen Thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated logic to wrap void return types in
Task<ApiResponse>whensettings.ReturnIApiResponseis true.