Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CustomCSharpPropertyNameGenerator #271

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

christianhelle
Copy link
Owner

This pull request implements the CustomCSharpPropertyNameGenerator class, which is used to generate property names in C# code based on a given JsonSchemaProperty. The implementation includes handling reserved characters and converting the property names to upper camel case. This implementation is taken directly from v14.0.0 of NSwag where it has changed the class accessibility to be sealed

This change is a prerequisite for upgrading to NSwag v14.0.0

@christianhelle christianhelle self-assigned this Jan 8, 2024
@christianhelle christianhelle changed the title Implement CustomCSharpPropertyNameGenerator Implement CustomCSharpPropertyNameGenerator Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4a3590) 97.41% compared to head (31f0cb9) 97.41%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files          60       60           
  Lines        2086     2090    +4     
=======================================
+ Hits         2032     2036    +4     
  Misses         37       37           
  Partials       17       17           
Flag Coverage Δ
unittests 97.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@christianhelle christianhelle merged commit 7253024 into main Jan 8, 2024
740 checks passed
@christianhelle christianhelle deleted the nswag-v14-prerequisites branch January 8, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant