Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize OperationNameGenerator enum as string #278

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

christianhelle
Copy link
Owner

@christianhelle christianhelle commented Jan 9, 2024

This pull request adds the [JsonConverter(typeof(JsonStringEnumConverter))] attribute to the OperationNameGenerator property in the RefitGeneratorSettings class.

Additionally, it sets the operationNameGenerator property to Default in the petstore.refitter file.

This resolves #277

@christianhelle christianhelle added bug Something isn't working enhancement New feature, bug fix, or request labels Jan 9, 2024
@christianhelle christianhelle self-assigned this Jan 9, 2024
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8736905) 97.46% compared to head (fa498ac) 97.46%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          60       60           
  Lines        2131     2131           
=======================================
  Hits         2077     2077           
  Misses         37       37           
  Partials       17       17           
Flag Coverage Δ
unittests 97.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle added .NET Pull requests that contain changes to .NET code bugfix Pull requests that contain bug fixes enhancement New feature, bug fix, or request and removed enhancement New feature, bug fix, or request bug Something isn't working labels Jan 9, 2024
@christianhelle christianhelle merged commit d7649c1 into main Jan 9, 2024
739 checks passed
@christianhelle christianhelle deleted the refitter-file-format branch January 9, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull requests that contain bug fixes enhancement New feature, bug fix, or request .NET Pull requests that contain changes to .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

operationNameGenerator enum not resolved from .refitter file
1 participant