Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Apizr] Docs updated about Apizr integration #432

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

JeremyBP
Copy link
Contributor

And finaly, here we are, the docs update final PR :)

Well that one is quite subjective as it depends on what you want to say, where and how.
Also, I'm french, so it may bring some english typos.
Feel free to fix it or ask me to or rephrase everything ^^

Jeremy

@JeremyBP
Copy link
Contributor Author

Maybe we should say somewhere that Apizr integration works well starting v6.0.0. Just wondering

@christianhelle christianhelle self-assigned this Jul 27, 2024
@christianhelle christianhelle added documentation Improvements or additions to documentation enhancement New feature, bug fix, or request labels Jul 27, 2024
@christianhelle
Copy link
Owner

@JeremyBP This is a great starting point

Well that one is quite subjective as it depends on what you want to say, where and how.
Also, I'm french, so it may bring some english typos.
Feel free to fix it or ask me to or rephrase everything ^^

My English isn't perfect either, I was born and raised in the Philippines and live in Copenhagen, Denmark. I'm sure the docs are already full of typos and language misuse. At some point, when I can pull myself together, I will check all documentation through some grammar optimization tool like Grammerly

Maybe we should say somewhere that Apizr integration works well starting v6.0.0. Just wondering

That would make sense. We will have users who learn about Apizr from Refitter and automatically start on the latest version. But it might be different for existing Apizr users, who would learn about Refitter while still on older versions of Apizr.

Copy link
Owner

@christianhelle christianhelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I'm fine with merging this as it is, but if you prefer to update the wording so it specifically mentions a minimum Apizr version requirement, then I can wait with merging the pull request.

I can also add the minimum Apizr version requirement texts myself, but that would have to wait until I'm officially back from my holidays 😄

@christianhelle
Copy link
Owner

@all-contributors please add @JeremyBP for docs

Copy link
Contributor

@christianhelle

I've put up a pull request to add @JeremyBP! 🎉

Copy link

@christianhelle christianhelle merged commit 2bd59e5 into christianhelle:main Jul 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants