Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullable annotations and disable warnings #452

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

christianhelle
Copy link
Owner

@christianhelle christianhelle commented Sep 2, 2024

This pull request enables nullable annotations in the code and removes explicit disable warnings. The change is replacing #nullable enable with #nullable enable annotations to the generated code

This resolves #451 (discussed in #449)

@christianhelle christianhelle self-assigned this Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (25f1f52) to head (b9708cc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files          72       72           
  Lines        3965     3966    +1     
=======================================
+ Hits         3807     3808    +1     
  Misses        116      116           
  Partials       42       42           
Flag Coverage Δ
unittests 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Sep 2, 2024
Copy link

sonarqubecloud bot commented Sep 2, 2024

@christianhelle christianhelle merged commit e454c84 into main Sep 2, 2024
6 checks passed
@christianhelle christianhelle deleted the fix-nullable-warnings branch September 2, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit #nullable enable introduced v1.2.0 produces excessive warnings
1 participant