Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Apizr] Deprecated Optional package removed from code & doc #539

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

JeremyBP
Copy link
Contributor

I just removed the now deprecated Apizr.Integrations.Optional package from generating code and documentation. Optional monad pattern wasn't used that much, complicated to understand and refreneced Optional.Async package was no longer maintained for years now.

I's a breaking change for those who are using Refitter with "WithOptionalMediation" but they still can reference the deprecated integration package manually. Like I said, I bet almost no body use it actually.

I updated the doc of course and the tests.
I upgraded build test referenced packages too.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (b34738d) to head (2f951c1).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   97.41%   91.89%   -5.52%     
==========================================
  Files          51       51              
  Lines        2517     2654     +137     
==========================================
- Hits         2452     2439      -13     
- Misses         42      181     +139     
- Partials       23       34      +11     
Flag Coverage Δ
unittests 91.89% <100.00%> (-5.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@christianhelle christianhelle self-assigned this Nov 25, 2024
@christianhelle christianhelle added documentation Improvements or additions to documentation enhancement New feature, bug fix, or request labels Nov 25, 2024
Copy link
Owner

@christianhelle christianhelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeremyBP looks good to me

Thanks for the contribution

@christianhelle christianhelle merged commit 9e5b009 into christianhelle:main Nov 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants