Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabling telemetry in MSBuild task #550

Merged
merged 3 commits into from
Dec 8, 2024
Merged

Conversation

christianhelle
Copy link
Owner

This pull request introduces a new feature to disable logging in the RefitterGenerateTask and updates the related MSBuild targets and tests accordingly. The most important changes include adding a new property to control logging, modifying the MSBuild targets to use this property, and updating the process execution logic to respect this setting.

New feature to disable logging:

Test project configuration:

@christianhelle christianhelle added enhancement New feature, bug fix, or request .NET Pull requests that contain changes to .NET code labels Dec 8, 2024
@christianhelle christianhelle self-assigned this Dec 8, 2024
Copy link

sonarqubecloud bot commented Dec 8, 2024

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (1d5057c) to head (4e88391).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   91.87%   98.91%   +7.03%     
==========================================
  Files          51       51              
  Lines        2657     2478     -179     
==========================================
+ Hits         2441     2451      +10     
+ Misses        181        4     -177     
+ Partials       35       23      -12     
Flag Coverage Δ
unittests 98.91% <ø> (+7.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle merged commit 87d396c into main Dec 8, 2024
9 checks passed
@christianhelle christianhelle changed the title Add support for disabling telemetry from MSBuild task Add support for disabling telemetry in MSBuild task Dec 8, 2024
@christianhelle christianhelle deleted the msbuild branch December 9, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request .NET Pull requests that contain changes to .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant